Integration of Agent/Environment with runner #332
+655
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Inherit from ABC if there @abstractmethods 2. Do not make gen_srun_success_check() abstruct, simply return an empty string by default. When needed, this method will be overriden.
Some slurm setups do not allow running enroot from the head node. Let's rely on actual 'enroot import' run via srun and report its real error message to user.
…e of the variables that is list.
…axtookbox definitions
* Remove conf/common/test/chakra_replay.toml * Remove conf/common/test_scenario/chakra_replay.toml
srivatsankrishnan
force-pushed
the
agent-env-integration
branch
from
2ab9ce4 to
96ab055
Compare
TaekyungHeo
reviewed
Jan 13, 2025
…rishnan/cloudai into agent-env-integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Integrates the agent, environment to gather all actions and uses existing runner to generate/launch jobs. This PR also closes the previous native Gym implementation PRand uses a simple abstract definition of Gym interface to have more control over the typing during integration.
Input
Output
Before
After Agent/Env integration
Test Plan
CI/CD.
Additional Notes
Include any other notes or comments about the pull request here. This can include challenges faced, future considerations, or context that reviewers might find helpful.